Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo that changes scale #714

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix typo that changes scale #714

merged 2 commits into from
Sep 8, 2023

Conversation

palday
Copy link
Member

@palday palday commented Sep 8, 2023

closes #713

@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
src/bootstrap.jl ø

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Benchmark Report for /home/runner/work/MixedModels.jl/MixedModels.jl

Job Properties

  • Time of benchmarks:
    • Target: 8 Sep 2023 - 23:11
    • Baseline: 8 Sep 2023 - 23:17
  • Package commits:
    • Target: 739aef
    • Baseline: 9ee4a0
  • Julia commits:
    • Target: bed2cd
    • Baseline: bed2cd
  • Julia command flags:
    • Target: None
    • Baseline: -Cnative,-J/opt/hostedtoolcache/julia/1.9.3/x64/lib/julia/sys.so,-g1,-O3,-e,using Pkg; Pkg.update(); Pkg.add(["BenchmarkTools", "StatsModels"])
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["crossed", "kb07:1"] 0.00 (5%) ✅ 0.00 (1%) ✅
["crossed", "machines:1"] 1.09 (5%) ❌ 1.00 (1%)
["crossed", "ml1m:1"] 0.96 (5%) 0.76 (1%) ✅
["crossed", "mrk17_exp1:1"] 0.02 (5%) ✅ 0.19 (1%) ✅
["crossed", "penicillin:1"] 1.09 (5%) ❌ 1.00 (1%)
["crossedvector", "d3:1"] 1.03 (5%) 0.48 (1%) ✅
["crossedvector", "kb07:2"] 1.16 (5%) ❌ 1.00 (1%)
["crossedvector", "kb07:3"] 1.12 (5%) ❌ 1.00 (1%)
["crossedvector", "mrk17_exp1:2"] 0.95 (5%) ✅ 0.65 (1%) ✅
["singlevector", "sleepstudy:2"] 1.15 (5%) ❌ 1.01 (1%)
["singlevector", "sleepstudy:3"] 0.00 (5%) ✅ 0.00 (1%) ✅
["singlevector", "sleepstudy:4"] 1.21 (5%) ❌ 1.01 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["crossed"]
  • ["crossedvector"]
  • ["nested"]
  • ["singlevector"]

Julia versioninfo

Target

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       4308 s          0 s        190 s       1593 s          0 s
       #2  2793 MHz       2444 s          0 s        200 s       3442 s          0 s
  Memory: 6.769481658935547 GB (4733.62109375 MB free)
  Uptime: 614.25 sec
  Load Avg:  1.15  1.08  0.7
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 5.15.0-1041-azure #48-Ubuntu SMP Tue Jun 20 20:34:08 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2793 MHz       5924 s          0 s        271 s       3184 s          0 s
       #2  2793 MHz       4959 s          0 s        282 s       4136 s          0 s
  Memory: 6.769481658935547 GB (4816.1796875 MB free)
  Uptime: 943.55 sec
  Load Avg:  1.11  1.33  0.98
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, icelake-server)
  Threads: 1 on 2 virtual cores

ararslan
ararslan approved these changes Sep 8, 2023
View reviewed changes
src/bootstrap.jl
@@ -180,7 +180,7 @@ families with a dispersion parameter.
- `hide_progress` can be used to disable the progress bar. Note that the progress
bar is automatically disabled for non-interactive (i.e. logging) contexts.
- `optsum_overrides` is used to override values of [OptSummary](@ref) in the models
fit during the bootstrapping process. For example, `optsum_overrides=(;ftol_rel=1e08)`
fit during the bootstrapping process. For example, `optsum_overrides=(;ftol_rel=1e-08)`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha nice

@palday palday merged commit f8e3203 into main Sep 8, 2023
10 checks passed
@palday palday deleted the palday-patch-1 branch September 8, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ftol_rel should be a small number, not a large number, right?
2 participants
@palday @ararslan